CONSOLE-3735: React router migration #13216

jhadvig · 2023-10-05T12:56:41Z

Replacement of #13094

openshift-ci-robot · 2023-10-05T12:57:09Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-05T13:00:31Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-05T13:01:12Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-05T13:01:36Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-05T13:02:16Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-05T13:02:40Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-05T13:03:08Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-05T13:03:48Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-05T13:04:08Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-12-01T03:09:36Z

@jhadvig: This pull request references CONSOLE-3735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-12-01T06:25:10Z

/retest-required

Remaining retests: 0 against base HEAD 2155d74 and 2 for PR HEAD 4e169d3 in total

jhadvig · 2023-12-01T09:35:30Z

/test e2e-gcp-console

jhadvig · 2023-12-01T12:15:05Z

Flake

level=info msg=Cluster operator monitoring Progressing is True with RollOutInProgress: Rolling out the stack.
level=info msg=Cluster operator network ManagementStateDegraded is False with : 
level=info msg=Cluster operator storage Progressing is True with GCPPDCSIDriverOperatorCR_GCPPDDriverControllerServiceController_Deploying: GCPPDCSIDriverOperatorCRProgressing: GCPPDDriverControllerServiceControllerProgressing: Waiting for Deployment to deploy pods
level=error msg=Cluster operator storage Available is False with GCPPDCSIDriverOperatorCR_GCPPDDriverControllerServiceController_Deploying: GCPPDCSIDriverOperatorCRAvailable: GCPPDDriverControllerServiceControllerAvailable: Waiting for Deployment
level=error msg=Cluster initialization failed because one or more operators are not functioning properly.
level=error msg=The cluster should be accessible for troubleshooting as detailed in the documentation linked below,
level=error msg=https://docs.openshift.com/container-platform/latest/support/troubleshooting/troubleshooting-installations.html
level=error msg=The 'wait-for install-complete' subcommand can then be used to continue the installation
level=error msg=failed to initialize the cluster: Cluster operators monitoring, storage are not available
Installer exit with code 6

/retest

rhamilto · 2023-12-01T13:37:09Z

/retest

openshift-ci-robot · 2023-12-01T18:15:25Z

/retest-required

Remaining retests: 0 against base HEAD e762b55 and 1 for PR HEAD 4e169d3 in total

rhamilto · 2023-12-01T18:48:56Z

@jhadvig, rebase required.

…strategy Completes steps 1, 4, and 5 of react-router migration strategy. Also addresses useParams and useLocation hooks from step 2 of migration strategy.

jerolimov · 2023-12-04T11:10:26Z

🫣

/lgtm

openshift-ci · 2023-12-04T11:12:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~dynamic-demo-plugin/OWNERS~~ [jerolimov,jhadvig,rhamilto]
~~frontend/OWNERS~~ [jerolimov,jhadvig,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rhamilto · 2023-12-04T12:52:25Z

/retest

cyril-ui-developer · 2023-12-04T12:52:47Z

frontend/__tests__/components/cluster-settings/basicauth-idp-form.spec.tsx

  beforeEach(() => {
-    wrapper = shallow(<AddBasicAuthPage />);
+    wrapper = mount(
+      <Provider store={store}>


Just seeing this. I think it would have been better to set up a reusable test render function for this instead of repeating, right?

yes, we could do it as a follow up 👍

openshift-ci-robot · 2023-12-04T17:11:03Z

/retest-required

Remaining retests: 0 against base HEAD 1935fa0 and 2 for PR HEAD 27bf86d in total

jhadvig · 2023-12-04T17:12:44Z

   Spec                                              Tests  Passing  Failing  Pending  Skipped

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✖ knative-ci.feature 0ms - - 1 - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✖ 1 of 1 failed (100%) 0ms - - 1 - -

jhadvig · 2023-12-04T23:01:51Z

/retest

jhadvig · 2023-12-04T23:02:44Z

  Logging in as kubeadmin
      Installing operator: "Red Hat OpenShift Serverless"
      Operator Red Hat OpenShift Serverless was not yet installed.
      Performing Serverless post installation steps
  1) "before all" hook for "Create knative workload using Container image with extrenal registry on Add page: KN-05-TC05 (example #1)"
  0 passing (2m)
  1 failing
  1) Perform actions on knative service and revision
       "before all" hook for "Create knative workload using Container image with extrenal registry on Add page: KN-05-TC05 (example #1)":
     AssertionError: Timed out retrying after 40000ms: Expected to find element: `[data-test="dropdown-menu-item-link"]`, but never found it. Queried from:
              > cy.get([data-test="namespace-dropdown-menu"], )
Because this error occurred during a `before all` hook we are skipping all of the remaining tests.
Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
      at Object.selectProject (webpack:////go/src/github.com/openshift/console/frontend/packages/dev-console/integration-tests/support/pages/app.ts:365:7)
      at createKnativeServing (webpack:////go/src/github.com/openshift/console/frontend/packages/dev-console/integration-tests/support/pages/functions/knativeSubscriptions.ts:9:19)
      at performPostInstallationSteps (webpack:////go/src/github.com/openshift/console/frontend/packages/dev-console/integration-tests/support/pages/functions/installOperatorOnCluster.ts:176:26)
      at verifyAndInstallOperator (webpack:////go/src/github.com/openshift/console/frontend/packages/dev-console/integration-tests/support/pages/functions/installOperatorOnCluster.ts:221:2)
      at verifyAndInstallKnativeOperator (webpack:////go/src/github.com/openshift/console/frontend/packages/dev-console/integration-tests/support/pages/functions/installOperatorOnCluster.ts:231:27)
      at Context.eval (webpack:///./support/commands/hooks.ts:7:33)

openshift-ci-robot · 2023-12-05T08:18:30Z

/retest-required

Remaining retests: 0 against base HEAD f829751 and 1 for PR HEAD 27bf86d in total

jhadvig · 2023-12-05T08:57:42Z

Overriding just in case the test would want to fail again, cause all the jobs passed

/override ci/prow/e2e-gcp-console

openshift-ci · 2023-12-05T08:59:45Z

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-gcp-console

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-12-05T09:04:30Z

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jhadvig changed the title ~~Console 3735 - React router migration~~ CONSOLE-3735: React router migration Oct 5, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 5, 2023

openshift-ci bot requested review from abhinandan13jan and bipuladh October 5, 2023 13:00

openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Oct 5, 2023

openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dashboard Related to dashboard labels Oct 5, 2023

openshift-ci bot added component/dev-console Related to dev-console component/gitops Related to gitops-plugin labels Oct 5, 2023

openshift-ci bot added component/helm Related to helm-plugin component/knative Related to knative-plugin labels Oct 5, 2023

openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Oct 5, 2023

openshift-ci bot added component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin labels Oct 5, 2023

openshift-ci bot added component/monitoring Related to monitoring component/network-attachment-definition Related to network-attachment-definition labels Oct 5, 2023

openshift-ci bot added component/olm Related to OLM component/pipelines Related to pipelines-plugin labels Oct 5, 2023

openshift-ci bot added component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Oct 5, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 1, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2023

CONSOLE-3710: Complete steps 1, 2, 4, 5 of react-router v6 migration …

27bf86d

…strategy Completes steps 1, 4, and 5 of react-router migration strategy. Also addresses useParams and useLocation hooks from step 2 of migration strategy.

jhadvig force-pushed the CONSOLE-3735 branch from 4e169d3 to 27bf86d Compare December 4, 2023 09:22

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2023

openshift-ci bot assigned jerolimov Dec 4, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023

cyril-ui-developer reviewed Dec 4, 2023

View reviewed changes

openshift-merge-bot bot merged commit 50d8364 into openshift:master Dec 5, 2023
6 checks passed

lokanandaprabhu mentioned this pull request Jan 31, 2024

OCPBUGS-28718: Revision tab and routes tab in serving details page showing no resource found #13556

Merged

4 tasks

rszwajko mentioned this pull request Mar 4, 2024

Missing match property in Console 4.15 kubev2v/forklift-console-plugin#965

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CONSOLE-3735: React router migration #13216

CONSOLE-3735: React router migration #13216

jhadvig commented Oct 5, 2023

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Dec 1, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Dec 1, 2023

jhadvig commented Dec 1, 2023

jhadvig commented Dec 1, 2023

rhamilto commented Dec 1, 2023

openshift-ci-robot commented Dec 1, 2023

rhamilto commented Dec 1, 2023

jerolimov commented Dec 4, 2023

openshift-ci bot commented Dec 4, 2023

rhamilto commented Dec 4, 2023

cyril-ui-developer Dec 4, 2023

jhadvig Dec 4, 2023

openshift-ci-robot commented Dec 4, 2023

jhadvig commented Dec 4, 2023

jhadvig commented Dec 4, 2023

jhadvig commented Dec 4, 2023

openshift-ci-robot commented Dec 5, 2023

jhadvig commented Dec 5, 2023

openshift-ci bot commented Dec 5, 2023

openshift-ci bot commented Dec 5, 2023

CONSOLE-3735: React router migration #13216

CONSOLE-3735: React router migration #13216

Conversation

jhadvig commented Oct 5, 2023

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Dec 1, 2023 • edited by openshift-ci bot

openshift-ci-robot commented Dec 1, 2023

jhadvig commented Dec 1, 2023

jhadvig commented Dec 1, 2023

rhamilto commented Dec 1, 2023

openshift-ci-robot commented Dec 1, 2023

rhamilto commented Dec 1, 2023

jerolimov commented Dec 4, 2023

openshift-ci bot commented Dec 4, 2023

rhamilto commented Dec 4, 2023

cyril-ui-developer Dec 4, 2023

Choose a reason for hiding this comment

jhadvig Dec 4, 2023

Choose a reason for hiding this comment

openshift-ci-robot commented Dec 4, 2023

jhadvig commented Dec 4, 2023

jhadvig commented Dec 4, 2023

jhadvig commented Dec 4, 2023

openshift-ci-robot commented Dec 5, 2023

jhadvig commented Dec 5, 2023

openshift-ci bot commented Dec 5, 2023

openshift-ci bot commented Dec 5, 2023

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 5, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Dec 1, 2023 •

edited by openshift-ci bot